From 940d4ad1295c15de01d065b618165f11a72dc37e Mon Sep 17 00:00:00 2001 From: Bert Peters Date: Sat, 2 Dec 2017 11:31:29 +0100 Subject: [PATCH] Clean up using shellcheck. --- 2017/day-02/solution.sh | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/2017/day-02/solution.sh b/2017/day-02/solution.sh index 88f2b1b..aeafd3e 100755 --- a/2017/day-02/solution.sh +++ b/2017/day-02/solution.sh @@ -3,8 +3,8 @@ sum1=0 sum2=0 -while IFS="\n" read line; do - sorted=$(echo $line | xargs -n 1 echo | sort -n) +while read -r line; do + sorted=$(echo "$line" | xargs -n 1 echo | sort -n) checksum=$(($(echo "$sorted" | tail -n 1) - $(echo "$sorted" | head -n 1))) for a in $sorted; do @@ -14,13 +14,13 @@ while IFS="\n" read line; do fi if [[ $((a % b)) -eq 0 ]]; then - sum2=$((sum2 + a / b)) + ((sum2 += a / b)) break fi done done - sum1=$((sum1 + checksum)) + ((sum1 += checksum)) done echo Sum 1: $sum1