From 3f3c95fd13f6df8e66f68029de42ca865df96a80 Mon Sep 17 00:00:00 2001
From: Bert Peters <bert@bertptrs.nl>
Date: Fri, 6 Apr 2018 13:55:00 +0200
Subject: [PATCH] Simpler coloring function for ReLU layers.

---
 src/fmri/visualisations.cpp | 11 +++--------
 1 file changed, 3 insertions(+), 8 deletions(-)

diff --git a/src/fmri/visualisations.cpp b/src/fmri/visualisations.cpp
index 814edf2..77710d9 100644
--- a/src/fmri/visualisations.cpp
+++ b/src/fmri/visualisations.cpp
@@ -162,6 +162,7 @@ static Animation *getReLUAnimation(const fmri::LayerData &prevState,
     caffe::caffe_sub(prevState.numEntries(), curState.data(), prevState.data(), changes.data());
 
     if (curState.shape().size() == 2) {
+        rescale(changes.begin(), changes.end(), 0, 1);
         EntryList results;
         for (auto i : Range(curState.numEntries())) {
             if (curState.data()[i] > EPSILON) {
@@ -169,15 +170,9 @@ static Animation *getReLUAnimation(const fmri::LayerData &prevState,
             }
         }
 
-        const auto maxValue = max_element(results.begin(), results.end())->first;
-
         return new ActivityAnimation(results, prevPositions.data(), curPositions.data(),
-                                     [=](float i) -> Color {
-                                                 if (maxValue == 0) {
-                                                     return {1, 1, 1, 1};
-                                                 } else {
-                                                     return {1 - i / maxValue, 1 - i / maxValue, 1, 1};
-                                                 }
+                                     [](float i) -> Color {
+            return {1 - i, 1 - i, 1};
                                              });
     } else {
         return new ImageInteractionAnimation(changes.data(), prevState.shape(), prevPositions, curPositions);